-
Notifications
You must be signed in to change notification settings - Fork 392
feat: string casing functions #6096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryThis PR adds seven string case conversion functions ( Implementation Details:
Test Coverage:
The implementation is clean, follows existing patterns, and provides useful string manipulation functionality that complements the existing Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant DataFrame
participant Expression
participant Functions
participant Rust_UDF
participant Heck
User->>DataFrame: df.select(col("text").to_snake_case())
DataFrame->>Expression: to_snake_case()
Expression->>Functions: to_snake_case(expr)
Functions->>Rust_UDF: _call_builtin_scalar_fn("to_snake_case", expr)
Rust_UDF->>Rust_UDF: ScalarFn::builtin(SnakeCase, vec![input])
Rust_UDF->>Rust_UDF: call(inputs)
Rust_UDF->>Rust_UDF: unary_utf8_evaluate()
Rust_UDF->>Heck: to_snake_case()
Heck-->>Rust_UDF: converted string
Rust_UDF-->>Functions: Series result
Functions-->>Expression: Expression result
Expression-->>DataFrame: Expression result
DataFrame-->>User: DataFrame with converted strings
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, no comments
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6096 +/- ##
===========================================
- Coverage 72.91% 43.42% -29.49%
===========================================
Files 973 910 -63
Lines 126196 112820 -13376
===========================================
- Hits 92016 48996 -43020
- Misses 34180 63824 +29644
🚀 New features to boost your workflow:
|
d0338b9 to
830742a
Compare
Changes Made
Use heck crate to convert cols and text between string casings.
Related Issues
Closes #2550.